search

devoxin / SharpLink

Lavalink wrapper for Discord.Net written in C#
MIT License
27 stars 6 forks source link

TrackEnd event - The Playing status is not correctly set #20

Closed FenikkusuKoneko closed 5 years ago

FenikkusuKoneko commented 6 years ago

Hi! On FireEvent with event type TrackEnd the reason can be "REPLACED" or "FINISHED" You should put a condition to check the reason. If the track is replaced this means a "skip" was occurred, the player plays the next track but the Playing status is false and this gives me some problems for example I can pause the current running player. When the player plays the next track the Playing status is set to true but, after, the Lavalink service send the TrackEnd event and the Playing status is set to false. If the track is finished then the Playing status can be false, this should be. Please fix it fast.

https://github.com/Devoxin/SharpLink/blob/3bb33574ec0d32f913c5afa2dd33b876073a7c34/SharpLink/LavalinkPlayer.cs#L146-L181

NovusTheory commented 6 years ago

Will get right on it

WorkingRobot commented 6 years ago

Any updates on this?