Conventional events for connection

devoxin / SharpLink

Lavalink wrapper for Discord.Net written in C#

MIT License

27 stars 6 forks source link

Conventional events for connection #24

Closed ghost closed 5 years ago

ghost commented 5 years ago

Added events that could be easily tied into discord connection events. More conventional than calling a pause & resume method for drops/resumes. As for the spacing changes, I copied most of this from my clone of Sharplink and R# did that.

NovusTheory commented 5 years ago

Where's the ConnectionLost/Resumed event implementation coming from?

ghost commented 5 years ago

Was debating on an issue/PR. Can you raise it? 😼

NovusTheory commented 5 years ago

I mean where is the event coming from that the switch case for it would ever get fired. It's inside the Lavalink websocket and afaik Lavalink has no event with those names. I'm confused what you're trying to do here

ghost commented 5 years ago

I was going to raise the event myself (aka you), I kind of forgot this is a wrapper. Whoops A for effort.