search

devoxx / cfp-speaker

Call for Paper frontent web application for speakers proposals
5 stars 12 forks source link

tweethandle should be optional #62

Open jayv opened 11 years ago

jayv commented 11 years ago

Today we had a speaker without tweethandle he had to use a fake handle to submit somthing, this field is optional in the DB, the UI should allow blanks.

LostInBrittany commented 11 years ago

In UserService.js the isProfileComplete function validates a profile, and for that service Twitter handle is optional.

In the view, speaker_details.html , tweethandle is not marked as required (no ng-required=true as the required attributes), so it shouldn't be required.

Testing to try to see where the problem is.

LostInBrittany commented 11 years ago

I fail to see where tweethandle is needed. I've just tried to create a new user, and it doesn't ask me for a tweet handle : user_creation