search

devpi / devpi-ldap

Plugin for devpi-server which provides LDAP authentication.
36 stars 20 forks source link

Refactor search conn #31

Closed jaraco closed 8 years ago

jaraco commented 8 years ago

These three commits reduce redundant code and attempt to consolidate certain behaviors to make the behavior easier to comprehend, including extracting a method with a docstring to encapsulate the behavior of building a search connection.

The changes are intended to perform the exact same functionality as the previous code. It's probably easier to review the PR by reading the commits in order, as they were broken down into three separate refactors.

fschulze commented 8 years ago

Was the config mutation the reason the search didn't work correctly?

jaraco commented 8 years ago

No, I still don't yet have a good answer for that other issue.