devpi / devpi-ldap

Plugin for devpi-server which provides LDAP authentication.
36 stars 20 forks source link

Clarify documentation of "attribute_name" #45

Open exhuma opened 5 years ago

exhuma commented 5 years ago

It was not immediately clear to me that attribute_name is subsequently used to bind with that attribute.

The process (from going through a debugger) is as follows:

The attribute I specified in the config did not return the DN of the user, but rather a "human-readable" name making the second bind-attempt failing. By simply specifying that attribute_name should contain the name of the attribute which contains the user's DN would have helped a lot.

fschulze commented 5 years ago

Could you make a PR? A PR done through the web interface of GitHub works just fine. Thanks in advance!

exhuma commented 5 years ago

Done: See #46

fschulze commented 5 years ago

Thanks! I will close this issue after next release.