devpunks / snuggsi

snuggsi ツ - Easy Custom Elements in ~1kB
https://snuggsi.com
MIT License
398 stars 17 forks source link

Get Lighthouse Certified #122

Open snuggs opened 7 years ago

snuggs commented 7 years ago

Reasoning: Compiance

Related: https://github.com/devpunks/snuggsi/issues/77

https://www.youtube.com/watch?v=d98CAgQNeaM https://googlechrome.github.io/lighthouse

May need some guidance on this one @brandondees @albertoponti @mrbernnz @tmornini @kurtcagle

Here's the example from Preact. (notice using localhost and https. The later i don't know how to do)

https://googlechrome.github.io/lighthouse/viewer/?gist=142af6838482417af741d966e7804346

Also, <a rel=noopener> seems interesting! Not sure if i understand the reasoning behind this. But shiny nonetheless ✨

albertopontonio commented 7 years ago

Reasoning: Compliance

Related: #77

I skimmed through the lighthouse tool, you can either add it to chrome as an extension or run it in the command line as a node module https://developers.google.com/web/tools/lighthouse/.

After your audit to view a report drag the json file into the viewer https://googlechrome.github.io/lighthouse/viewer/.

I will look into the audit references of the first audit report that I found here https://developers.google.com/web/tools/lighthouse/audits/address-bar.

The report json file is attached here if you want to take a look. snuggsi.herokuapp.com_2017-07-24_18-30-56.json.zip

@snuggs @tmornini @brandondees @kurtcagle @mrbernnz

snuggs commented 7 years ago

@albertoponti cazzo that's awesome research. Feel free to add a Pull Request in /index.html for the theme-color meta tag. https://developers.google.com/web/updates/2014/11/Support-for-theme-color-in-Chrome-39-for-Android

snuggs commented 7 years ago

@albertoponti we should add this to the list of tests as well. People seem to be using it as a benchmark.

http://www.webpagetest.org

albertopontonio commented 7 years ago

Will do :)

Sent from my iPhone

On Aug 15, 2017, at 7:15 AM, snuggs notifications@github.com wrote:

@albertoponti we should add this to the list of tests as well. People seem to be using it as a benchmark.

http://www.webpagetest.org

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

snuggs commented 7 years ago

@albertoponti @cristhiandick #PING

albertopontonio commented 7 years ago

@snuggs @brandondees @tmornini .. ran the webpagetest, you can find the results here http://www.webpagetest.org/result/170927_CC_d13aedc2af12aff1e881654b79091392/ .. it "failed" the compress transfer, cache static content. There are some other warnings to go over.

snuggs commented 7 years ago

Should be able to fix a bunch of "errors" by sending back cache headers. That should clear out 50% of the "issues". Great we are even doing this nonetheless @albertoponti