search

devpunks / snuggsi

snuggsi ツ - Easy Custom Elements in ~1kB
https://snuggsi.com
MIT License
395 stars 17 forks source link

include snugssi before links #177

Closed icyc9 closed 5 years ago

icyc9 commented 5 years ago

example is broken and elements aren't instantiating. moved snuggsi import to above the link tags. @snuggs

snuggs commented 5 years ago

Hmmmmm @RobertChristopher it's a bug if we want to make it a feature. :-) (For now) This looks good. But TECHNICALLY a good user experience would be if where <script src=snuggsi...> is inconsequential. (At least I thought it worked that way for custom elements).

I'm taking a look as well but this looks good regardless. Nice catch by the way. I've definitely experienced this before. Now we can actually have a test for it due to work @brandondees and @tmornini and I did with test coverage. #162, #70, #62

brandondees commented 5 years ago

It would be really nice if we can achieve that but until we can prove that's a safe assumption to rely on, I'd rather say don't assume it can do that and always load the dependency first. @snuggs the CI hook seems to not be responding but it passed already. Merge away.

snuggs commented 5 years ago

Well done @brandondees