Update vscode settings - Githubissues

devpunks / snuggsi

snuggsi ツ - Easy Custom Elements in ~1kB

https://snuggsi.com

MIT License

395 stars 17 forks source link

Update vscode settings #205

Closed snuggs closed 4 years ago

snuggs commented 4 years ago

Description

Fixes bug in .vscode/settings.json
Adds .test extension to vscode

Motivation and Context

Test files have a .test extension but contain javascript (for this project)

How Has This Been Tested?

@rianby64 can you quarterback this? ICANHAZ VIM. 🐱 /cc @brandondees

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/sneakyhead/snuggsi/eshsyq310 ✅ Preview: https://snuggsi-git-update-vscode-settings.sneakyhead.now.sh

brandondees commented 4 years ago

Yeah I don't have a definite answer, other than to look into alternative formats that support the use cases better, or to create a workaround that complies with the format's rules


{
  'foo': 1,
  '_comment': "Let's explain some stuff"
}

brandondees commented 4 years ago

I'll try to take a look at testing this setup tomorrow

snuggs commented 4 years ago

@brandondees cool. This should be good to go and make @rianby64 happy. Care to review so i can haz merge??