devrandom / gitian-builder

Build packages in a secure deterministic fashion inside a VM
https://gitian.org/
Other
402 stars 226 forks source link

By default, cleanup the target after use #234

Closed jasonbcox closed 4 years ago

jasonbcox commented 4 years ago

After running gbuild, the VM is left running. This unnecessarily consumes system resources if left alone.

I don't see a strong rationale for leaving the VM dangling after running, especially since gbuild always cleans up the old VM at the start of each execution (see line 54, where stop-target is called). By default, the VM should be stopped. A new option has been added to override this behavior, should it be useful in other configurations.