search

devrnt / react-use-intercom

☎️ React Intercom integration without the hassle, powered by hooks.
https://devrnt.github.io/react-use-intercom/#/useIntercom
MIT License
337 stars 43 forks source link

Follow up: window.intercomSettings #502

Open devrnt opened 2 years ago

devrnt commented 2 years ago

It seems like window.intercomSettings isn't used in SPAs, according to https://github.com/devrnt/react-use-intercom/pull/481#issuecomment-1148940938. This is confirmed by someone from Intercom. We should follow this up and check for updated documentation, so we can remove the use window.intercomSettings uses in this codebase

devrnt commented 2 years ago

Also note that in both boot and update the "old" window.intercomSettings are spread into the new window.intercomSettings. So by removing the use of these global settings, we should introduce our own global settings reference