search

devrnt / react-use-intercom

☎️ React Intercom integration without the hassle, powered by hooks.
https://devrnt.github.io/react-use-intercom/#/useIntercom
MIT License
333 stars 43 forks source link

Typo showNewMessage not showNewMessages #591

Closed DevBrent closed 1 year ago

DevBrent commented 1 year ago

Ahh, I see this problem is deeper. This would require a version change not just a documentation fix.

https://github.com/devrnt/react-use-intercom/blob/af5e9f5fc4b9d374a73d843457622d17a129ef64/src/provider.tsx#L177

Why was the term showNewMessages implemented when the intercom call is "showNewMessage" and the intended behavior is for it to open a new blank or preseeded chat in the intercom widget.

The intent of "useIntercom" was to implement the intercom API even referring to the intercom API docs. This needs to be fixed.

devrnt commented 1 year ago

Hi, thanks for creating this draft. The issue that you address is valid, it is indeed a typo. Are you willing to pick it up? It can be released as the next major version

devrnt commented 1 year ago

v3.0.0