devrnt / react-use-intercom

☎️ React Intercom integration without the hassle, powered by hooks.
https://devrnt.github.io/react-use-intercom/#/useIntercom
MIT License
328 stars 43 forks source link

Use lower node version to prevent npm claims about node < 18 #638

Closed eaglus closed 1 year ago

eaglus commented 1 year ago

Why node version 16 is too old to install react-use-intercom? I think, we should remove { node: '>=18' } requirement or make node version lower at least to 14

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'react-use-intercom@5.0.0',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.19.1', npm: '8.19.3' }
npm WARN EBADENGINE }
devrnt commented 1 year ago

Thanks for creating this issue. I don't consider this to be an issue. Notice that the log is just a warning and is not breaking anything (except if you pass --engine-strict). I want to keep track of the Node LTS version (which is 18 at this moment).

JamieDixon commented 1 year ago

Hey @devrnt Thanks for your work on this project. Very much appreciated.

I just wanted to add to the conversation that when using yarn this requirement for node >=18 prevents the package from being installed. Rather than being a warning, it's an error that can only be bypassed using the --ignore-engines flag.

It's a not a massive issue but it did break our CI/CD pipeline and it's a shame to use this flag since we might miss genuine issues with other packages.

I hope this comes across as intended, as an FYI for you to consider rather than any kind of complaint.

Thanks again for all your work here. It's very much appreciated.

devrnt commented 1 year ago

Thanks for coming back to this @JamieDixon. I've reproduced this and indeed yarn does throw an error, thanks for pointing this out. I'll just remove the engines entry since it has no added value in user-land

devrnt commented 1 year ago

v1.5.4