search

devrnt / react-use-intercom

☎️ React Intercom integration without the hassle, powered by hooks.
https://devrnt.github.io/react-use-intercom/#/useIntercom
MIT License
333 stars 43 forks source link

fix: next example now works #652

Closed multivoltage closed 1 year ago

multivoltage commented 1 year ago

Fixed

For my previus PR I noticed that nextjs did not work since it use a different react version. I fixed using same version.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: e040edd5a73f55be0230f85dc67279956545d637

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

devrnt commented 1 year ago

I ran this locally and seems like this is still not working

multivoltage commented 1 year ago

What task did you run?

multivoltage commented 1 year ago

@devrnt I installed pnpm@7.26.3 and reverted these 4 lines. Then I Run "build" "build-playground" and "test" without error.

devrnt commented 1 year ago

I'm running the dev:examples script. Seems like there are 2 versions of React in the nextjs example

multivoltage commented 1 year ago

I don't know. Before my commit there was 2 version of react between next and gatasby. Now There is only 18.2.0. I delete and clone again my branch. Run: pnpm run install, pnpm run dev, pnpm run dev-examples, pnpm run build. All these task finish ok in my local ;(

devrnt commented 1 year ago

Big thanks!