search

devrok / colmar-academy

0 stars 0 forks source link

SUMMARY #7

Open aubreywullschleger opened 6 years ago

aubreywullschleger commented 6 years ago

Grade: Exceeds expectations

Summary: Spectacular work on this final project! I love your organized, semantic HTML, your use of alt attributes, and that your page is totally responsive. Also, your use of role="presentation" went above and beyond expectations for this project.

A few things to work on would be: 1. using more descriptive alt attributes, 2. using correct syntax for the <video> element and its attributes, and 3. making your CSS more concise by using group selectors for repeated styles and a single media query per page width.

Next, I challenge you to build more pages for this site. What does a sign in page look like? What about a course page? Building these extra pages will add some complexity and is a challenge I think you are ready for based on your work here!

devrok commented 6 years ago

Thank you for your honest feedback and the many tips and tricks. Also thanks, for the sources where I can get more suggestions to improve my work.