search

devryan / GamePanelX-V3

The Original Free and Open Source Game Control Panel
https://www.gamepanelx.com
Other
131 stars 94 forks source link

php7 Support #155

Open zarlo opened 7 years ago

zarlo commented 7 years ago

GamePanelX-V3 will not work on php7

147

148

ghost commented 7 years ago

I am trying to fix this myself, but I will only test this on PHP 7

devryan commented 7 years ago

If you fix it and I test it I'll merge it into master

On Feb 16, 2017 6:32 AM, "Wimmie13" notifications@github.com wrote:

I am trying to fix this myself, but I will only test this on PHP 7

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/devryan/GamePanelX-V3/issues/155#issuecomment-280345644, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVBNtjuQ5wouovrE6GtmvwNn7Jg7wfLks5rdF4DgaJpZM4Lca8B .

ghost commented 7 years ago

Okay. It works on PHP 7.0 right now, but I also came across a lot of bugs in the SQL.

ghost commented 7 years ago

In the following code PHP 7.0 support is added, some query bugs are fixed and the SQL files are changes so they have default values. There are still some bugs that must be fixed. The tag is deprecated and inline styling is not the best way to style the website. I thing that classes can be better for better code reading etc. The mysql is a global variable used by $GLOBALS. This should be something else like a database class. The query's should be added to here so it is easy'er to find and edit them. GamePanelX-V3-master.zip I also have a problem when trying to create a Steam server. I dont know if this is by my doing with the PHP or the server, but for some reason it stops after downloading a few items.

dhalucario commented 7 years ago

When is this fix going to be pushed?