devryan / GamePanelX-V3

The Original Free and Open Source Game Control Panel
https://www.gamepanelx.com
Other
131 stars 94 forks source link

New Server creation fails due to $tplid not being defined #40

Open RogEnk opened 11 years ago

RogEnk commented 11 years ago

Latest source from Git will result in inability to create new servers from new templates.

Example: Cloud L4D2 server, template is created fine. Attempt to install new server using template and error returns: "Failed: No Game ID or empty/invalid Template ID specified!"

Line 346 of includes/classes/server.php has "if(!empty($tplid) && is_numeric($tplid)) {" However $tplid tests fail on both counts because it is never intitialised nor is it given a value anywhere! So script drops through to line 354 and aborts.

devryan commented 11 years ago

Completely unable to reproduce this bug.

My template gets to 100%, goes into "Running" state, finishes creating the tarball, shows as "complete". Creating a server also runs easily and successfully.

Is your template set as default, on l4d2? Does this also happen on other steam games, such as CS:Source? Have you had a working template before, but only with recent github code, did this issue occur?

RogEnk commented 11 years ago

I have now re-installed the Master Server (rolled back) and will attempt this again after updating to github version, it occurred with L4D2 and GMod using template set as default with the latest GitHub source. Remotes are still on github release version.

devryan commented 11 years ago

This may also be a simple javascript issue as mentioned in a previous post; make sure to refresh a few times and/or clear your browser's cache, logout/login before trying again.

gbobr commented 11 years ago

I have reported the same problem in #33 But i couldn't reproduce it again so i closed the report. Not sure what caused it