devs-immortal / Paradise-Lost

Paradise awaits...
https://immortaldevs.net/paradise-lost/
MIT License
199 stars 43 forks source link

Crash: Incompatibility with Medieval Items [1.20.1 and probably 1.20] #805

Closed TheShadyyOneYT closed 2 months ago

TheShadyyOneYT commented 2 months ago

What were you doing when the crash occured? How can we replicate it?

  1. First, Download medieval weapons mod, latest version for game version 1.20.1
  2. Next, download the new beta for fabric 1.20.1 of paradise
  3. Launch the game and Finally, game crashes specifying: https://pastebin.com/fasiFv1G

Versions: Medieval Weapons: 1.4.8 Paradise Lost: beta 2.2.1 Fabric Modloader: 0.16.2 Fabric API: 0.92.2 Game Version: 1.20.1

Did it crash the client or server?

Client

Mod Version

Beta 2.2.1

Fabric API Version

0.92.2

Crash Report

https://pastebin.com/fasiFv1G

Other mods

Medieval weapons is the cause of it currently: https://www.curseforge.com/minecraft/mc-mods/medievalweapons/files/4819203

Modlist: Screenshot 2024-08-18 231943 Screenshot 2024-08-18 231958 Screenshot 2024-08-18 232013 Screenshot 2024-08-18 232020

Additional Information

Not really, just a small incompatibility I think or something that could be resolved. I have no idea honestly, I hardly understand code other than the fact I could determine which mod was the issue.

But here in the crash report this is where It occured I believe on my limited knowledge:

Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.NullPointerException [in thread "Render thread"] at net.minecraft.class_1831.<init>(class_1831.java:7) at net.minecraft.class_1766.<init>(class_1766.java:24) at net.minecraft.class_1821.<init>(class_1821.java:35) at net.id.paradiselost.items.ParadiseLostItems.<clinit>(ParadiseLostItems.java:87) at net.id.paradiselost.items.tools.ParadiseLostToolMaterials.<clinit>(ParadiseLostToolMaterials.java:11) at net.medievalweapons.compat.CompatItems.loadItems(CompatItems.java:232) at net.medievalweapons.init.ItemInit.init(ItemInit.java:141) at net.medievalweapons.MedievalMain.onInitialize(MedievalMain.java:22) ... 7 more Caused by: java.lang.ExceptionInInitializerError at net.id.paradiselost.items.tools.ParadiseLostToolMaterials.<clinit>(ParadiseLostToolMaterials.java:11) at net.medievalweapons.compat.CompatItems.loadItems(CompatItems.java:232) at net.medievalweapons.init.ItemInit.init(ItemInit.java:141) at net.medievalweapons.MedievalMain.onInitialize(MedievalMain.java:22) at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:399) ... 6 more Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1832.method_8025()" because "$$0" is null at net.minecraft.class_1831.<init>(class_1831.java:7) at net.minecraft.class_1766.<init>(class_1766.java:24) at net.minecraft.class_1821.<init>(class_1821.java:35) at net.id.paradiselost.items.ParadiseLostItems.<clinit>(ParadiseLostItems.java:87)

MBatt1 commented 2 months ago

Yeah this might be an issue with the 'efficient' way that tool materials are being added by PL, I will work on a fix for 1.20 and check lower the 1.19 version as well

MBatt1 commented 2 months ago

Doesn't appear to be a problem for 1.19.x or 1.20.0 but 1.20.1 is crashing

PixelatedBruh commented 2 months ago

I have a personal fork of medieval weapons that i have been slowly adding compatibility for mythic metals and ran into this issue when testing. after about idk 15 mins of messing with it I couldn't get it to work on my side.

TheShadyyOneYT commented 2 months ago

I have a personal fork of medieval weapons that i have been slowly adding compatibility for mythic metals and ran into this issue when testing. after about idk 15 mins of messing with it I couldn't get it to work on my side.

the only thing that worked for me temporarily is to downgrade medieval weapons to 3.4.7 and wait for a fix in the mean time till 3.4.8 is fixed.

MBatt1 commented 2 months ago

image Fixed in b2.2.3 1.20/1.20.1 (I haven't released it yet)

MBatt1 commented 2 months ago

It looks like there's a recipe issue but that's on their end, idk how they generate the recipes but something's wrong with the olvite longsword, in case you want to open an issue over with them

[16:52:49] [Render thread/ERROR]: Parsing error loading recipe medievalweapons:olvite_long_sword
com.google.gson.JsonSyntaxException: Unknown item 'betterend:olvite'
    at net.minecraft.class_1869.method_17878(class_1869.java:272) ~[client-intermediary.jar:?]
    at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
    at net.minecraft.class_1869.method_8155(class_1869.java:272) ~[client-intermediary.jar:?]
    at net.minecraft.class_1856.method_8107(class_1856.java:160) ~[client-intermediary.jar:?]
    at net.minecraft.class_1856.method_8102(class_1856.java:143) ~[client-intermediary.jar:?]
    at net.minecraft.class_1869.method_8157(class_1869.java:252) ~[client-intermediary.jar:?]
    ...
TheShadyyOneYT commented 2 months ago

Ok thank you! I will show them.

MBatt1 commented 2 months ago

Just pushed 2.2.3 out, I'm closing this but please reopen if the mod loading still has issues!

TheShadyyOneYT commented 2 months ago

Good to hear! I will go ahead and get the message out, and to confirm, there isn't a crash anymore! I thank you very much for this fix :)