devs-immortal / Paradise-Lost

Paradise awaits...
https://immortaldevs.net/paradise-lost/
MIT License
199 stars 43 forks source link

Bug: Distant Horizons loads overworld chunks #817

Open MrXBlade opened 6 days ago

MrXBlade commented 6 days ago

What happened?

It seems there is no proper world-type definition for Distant Horizons

  1. Load in a world with Distant Horizons
  2. Go through the portal
  3. See how Paradise Lost chunks generate ontop of the overworld ones

Possibly helpful post

Mod Version

2.2.7-beta

Fabric API Version

0.105.0

Relevant log output

No response

Other mods

No response

Additional Information

No response

MBatt1 commented 4 days ago

I am not able to replicate this, 1.21 with latest version of DH 2.2.1 I generated chunks in overworld, entered paradise and then exited and everything seems fine to me? Do you have any other mods or anything that might interfere?

https://github.com/user-attachments/assets/23007460-c328-4bdd-b361-f6260dcb5faf

MrXBlade commented 4 days ago

How odd..

I have a big list of mods that I can post, but the only ones I can imagine interfering is C2ME or The Bumblezone? Since it adds another dimension (That one works)

I'm specifically on 1.21.1

MBatt1 commented 4 days ago

hm I just tried on 1.21.1 and it seems fine... would it be possible for you to remove c2me and see if the problem still exists? if not please paste your whole modlist here

MrXBlade commented 3 days ago

https://github.com/user-attachments/assets/dc2fa0a7-2b37-41b5-81a6-e5f22423c851

MBatt1 commented 3 days ago

Hm okay sorry I should have tested it on a server- I can confirm this is a problem with only PL and DH installed

The fix is going to the DH settings -> advanced -> multiplayer -> Set "Multi Dimension Required Similarity" to 0.8 I no longer saw chunk weirdness with this toggled, this is based on the FAQ I found on the DH git repo

Let me know if this fixes it or not and I can close this ticket out

MrXBlade commented 3 days ago

All good, I never specified that

Last time I set my MDRS to 0.8, it started generating new LOD's for the overworld (in another folder) I had to reset the Overworld spawn chunks to make sure it didn't detect it as the same world again

When setting it to 0.8 this time, making sure everything is properly set, split/not merged, it will continuously generate new folders for PL everytime you pass through the portal

But I'm assuming there would be a way to fix this issue, The Bumblezone is saved in a folder called "dimension_special_effects" If that folder specifically were auto-generated for a modded dimension, I'd then think PL would overwrite that, but that's not the case either

MBatt1 commented 1 day ago

Hmm I'll have to figure this out still that is very weird. I guess for the time being it is an incompatability but I don't see anything obvious that bumblezone does that PL doesn't in the worldgen files...