devsargam / SnakeGame

A simple snake game made with vanilla javascript.
https://snakeinjs.netlify.app/
MIT License
29 stars 22 forks source link

Added Game Over modal functionality #51

Closed thisisamish closed 2 years ago

thisisamish commented 2 years ago

This PR will solve issue #47.

I have added a modal in the index.html file that displays the game over message in the middle of the screen. Since the game over message display is being handled by this modal, I have removed the game over div. Please let me know if there are any issues still remaining or if I should explain the changes any further. Also, this is my first PR ever! :)

netlify[bot] commented 2 years ago

Deploy Preview for snakeinjs ready!

Name Link
Latest commit be14f4260fc5a588ddb93c9abc3cfec6e93c2ab9
Latest deploy log https://app.netlify.com/sites/snakeinjs/deploys/6348e196109c73000855d698
Deploy Preview https://deploy-preview-51--snakeinjs.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

devsargam commented 2 years ago

@thisisamish as this is your first pr I'll try my best to help you! I don't think you have much experience contributing to opensource but generally you need to open an issue or as the owner of repo or the issue creater to assign you the issue and only then start working on it. This is your first one so keep it in mind from now on.

devsargam commented 2 years ago

@thisisamish in my 14' laptop I don't think thats how the modal should look. Could you fix it by making the font slightly smaller or by making the modal slightly bigger image

thisisamish commented 2 years ago

Yeah, sure. I'm on it. Also, thank you for assigning this issue to me and tagging it with hacktoberfest-accepted. I didn't have a good idea of how all this works so it was really cool of you to do this. :)

devsargam commented 2 years ago

@thisisamish feel free to star this project :clinking_glasses:

thisisamish commented 2 years ago

sure. would be happy to. 😊

thisisamish commented 2 years ago

Hey @devsargam, I have made the modal slightly bigger and the text slightly smaller. I tested it on a 14" laptop screen in Chrome browser and it is working fine now. Could you please check at your end?

devsargam commented 2 years ago

@thisisamish looks fine.

devsargam commented 2 years ago

fixes: #47