search

devsecops / bootcamp

A open contribute bootcamp to develop DevSecOps skills...
Apache License 2.0
710 stars 353 forks source link

Edit lab #87

Closed inkrypto closed 8 years ago

inkrypto commented 8 years ago

Removed "Bundle exec" to start rails server.

colinross commented 8 years ago

I have to disagree with the edits specifically to the Lab (0614db8fe9e5)

Running gem-based executables without bundle exec may work for you, in your environment. If it does than I assume the executable happens to be installed in your system and does not conflict with your bundle. Unfortunately, this is unreliable and also a creator of lots of 'wtf' moments.

Running with bundle exec will ensure the right gem versions are used according to the Gemfile.lock and avoid any issues along those lines. This is essentially WHY bundle exists in the first place-- to ensure consistency of gem versions across environments.

tl;dr Even if it looks like it works without bundle exec, it may not work in the future or on another machine without bundle exec.

As for using the rails s shortcut, well, I feel keeping the ruby/rails stuff as explicit as possible is better in the context of the bootcamp labs as some of the participants are literally using rails for the first time.

Just my own two cents.

pbnj commented 8 years ago

For best practices, we will keep bundle exec. As for command shortcuts (e.g. rails s), we can educate users about this feature, but we should keep the full commands for reference-sake.