search

devsecopsmaturitymodel / DevSecOps-MaturityModel

GNU General Public License v3.0
460 stars 266 forks source link

Sorting in the "Mappings" view not working as expected #221

Closed jonashirner closed 1 year ago

jonashirner commented 1 year ago

Sorting in the "Mappings" view is not working as expected and should be fixed. As a consequence the export functionality also is producing wrong data as it uses the same algorithm.

As an example, the Activity "Usage of a vulnerability management system" in Test and Verification / Consolidation has 5 ISO references assigned to it:

image

By sorting by ISO I would expect 5 lines for the named activity, one for each referenced ISO norm. Instead there are three lines with the same content / reference (16.1.6)

image

The same bug occurs when sorting by SAMM.

wurstbrot commented 1 year ago

@0x41head do you have an idea?

0x41head commented 1 year ago

Fixed this issue.

Seems like JS was updating the same object over and over again. Something like this stack overflow question.

No idea as to why this was not an issue earlier.

P.S. @wurstbrot massive apology for the direct push to you repo. I did not realize I was not on my fork.

wurstbrot commented 1 year ago

@0x41head next time in PR. Thank you for the fix.