search

devsecopsmaturitymodel / DevSecOps-MaturityModel

GNU General Public License v3.0
460 stars 266 forks source link

Activity Tag filter added in matrix component #223

Closed ptechofficial closed 1 year ago

ptechofficial commented 1 year ago

In regards to Issue #212, This commit will add the tags view in the task description. It also has some groundwork for the filter.

P.S. This is still a work in progress.

wurstbrot commented 1 year ago

cool, thank you @ptechofficial

I marked it as draft, as you still want to do something. What enhancements do you see?

ptechofficial commented 1 year ago

I am adding another filter below the sub-dimension filter. This will work like the chip filter only, there will be a link between the two filters(sub-dimension and activity). For eg, if a sub-dimension is removed, all the activity tags will also be removed.

Currently I am working on that functionality.

ptechofficial commented 1 year ago

Hi @wurstbrot, I have successfully added Activity Tag Filter in Matrix Component.

You can close this Issue now.

wurstbrot commented 1 year ago

Thank you, I like your PR. I added some naming suggestions.

After removing a tag, how can I re-add it?

ptechofficial commented 1 year ago

I will update the name and changes you suggested.

For re-adding a tag, there is an auto-complete function. But I just checked it and it isn't working properly. I'll fix it now.

ptechofficial commented 1 year ago

Hi @0x41head, I have worked on the mentioned bug.

Thanks for the suggestion, I have created a generalized function that will be called for both filters. This will check both the tags ( SubDimension and Activity) and will present the result accordingly.

0x41head commented 1 year ago

@wurstbrot what do you think about adding a chip called "tags not defined" for the activities that don't have tags ?

wurstbrot commented 1 year ago

@wurstbrot what do you think about adding a chip called "tags not defined" for the activities that don't have tags ?

Good idea!

ptechofficial commented 1 year ago

Hi @0x41head Could you please explain this "tags not defined" feature?

0x41head commented 1 year ago

We want to make sure that we include activities/tasks that do not have the attribute tags. So we'd like to add a new chip called tag not defined to the filter tag. This will filter out all actions with no tags attributes or with an empty tags property.

ptechofficial commented 1 year ago

Closing because of the new PR