search

devsecopsmaturitymodel / DevSecOps-MaturityModel

GNU General Public License v3.0
460 stars 266 forks source link

Overlay for Comprehensive Heatmap #232

Closed ptechofficial closed 12 months ago

ptechofficial commented 1 year ago

This PR is dealing with issue #192

Will be creating an overlay which would look something like this: image

wurstbrot commented 1 year ago

Hi @ptechofficial ,

as soon as you are done, please remove "WIP" and request a review from @0x41head and me.

wurstbrot commented 1 year ago

I feel the removed console logs are helpful. Why remove?

0x41head commented 1 year ago

Agreed. Alternatively, we can create a production branch, which doesn't log anything.

wurstbrot commented 1 year ago

Agreed. Alternatively, we can create a production branch, which doesn't log anything.

What do you mean by "product branch"? You mean a feature toggle for debugging which is disabled by default and enabled in development?

0x41head commented 1 year ago

What do you mean by "product branch"? You mean a feature toggle for debugging which is disabled by default and enabled in development?

That could work as well, but I was thinking more in the lines of having a separate branch that doesn't log anything and people could use that if they wanted a more "clean" build of DSOMM

ptechofficial commented 1 year ago

There are a few console logs that were commented out. Should I keep them as well?

wurstbrot commented 1 year ago

There are a few console logs that were commented out. Should I keep them as well?

yes please