search

devsecopsmaturitymodel / DevSecOps-MaturityModel

GNU General Public License v3.0
460 stars 266 forks source link

Added schemas for validation of DSOMM yamls #236

Closed Tamronimus closed 12 months ago

Tamronimus commented 1 year ago

Hello @wurstbrot

What do you think about this approach? Thanks to the definition of the schema, certain schematic errors can be recognised directly (if you have yaml validation in the IDE). If I have time soon, I can look into some of these errors.

Tamronimus commented 12 months ago

Hi I fixed the easy errors detected by the schema, mostly duplicate keys and typos.

wurstbrot commented 12 months ago

great, thank you!

wurstbrot commented 12 months ago

In the long run, we should implement a quality gate in github actions validating the yamls

wurstbrot commented 12 months ago

Are you able to sign your commits (if not, I will merge)?

Tamronimus commented 12 months ago

Hi @wurstbrot I signed the commits, but i made a mistake and it created new commit id's, can you please merge this PR for me. In future changes i will sign the commits directly. Sorry for that.

wurstbrot commented 12 months ago

thx