devshawn / kafka-gitops

๐Ÿš€Manage Apache Kafka topics and generate ACLs through a desired state file.
https://devshawn.github.io/kafka-gitops
Apache License 2.0
322 stars 71 forks source link

support PREFIXED consumer groups #48

Open fholzer opened 3 years ago

fholzer commented 3 years ago

Are there any plans to support PREFIXED consumer groups (service type: application)?

For now I implemented this at in my fork though as I'm not familiar with the code base and only need this for service type application I didn't touch files related to other service types.

devshawn commented 3 years ago

Hi @fholzer, I'm happy to support this enhancement. I'll likely use your implementation as a starting point and get a release built sometime this week -- does that help you out? ๐Ÿ˜„

fholzer commented 3 years ago

Hi Shawn, that sounds really great. That way I don't have to maintain my fork with that patch applied ;) Cheers/f

devshawn commented 3 years ago

Hi @fholzer, sorry for the delay. I hope to have this added and released by the end of the week. Thanks!

fholzer commented 3 years ago

No worries at all. As long as there's no other new features we're interested in, we're fine with using my fork for now. ๐Ÿ˜‹