search

devshawn / kafka-gitops

🚀Manage Apache Kafka topics and generate ACLs through a desired state file.
https://devshawn.github.io/kafka-gitops
Apache License 2.0
321 stars 71 forks source link

is it possible to specify multiple operations related to a single resource for acts #61

Open mundey opened 3 years ago

mundey commented 3 years ago

when needed to specify entries for a service account but operations on same topic/group/resource, there is repetition. could it be possible to add operations in a single entry:

customServiceAcls:
  dev_mgmt-test:
    d-cg-thg:
      name: test.hello-group
      type: GROUP
      pattern: LITERAL
      host: "*"
      operation: DESCRIBE,DESCRIBE_CONFIGS,READ
      permission: ALLOW
gquintana commented 3 years ago

I agree, this would make state file less verbose. And it would be closer to what kafka-acl tool can do in a single run. But it would make plan computation harder I guess.

devshawn commented 3 years ago

This was a stylistic choice we made when building the tool -- for custom ACLs, we wanted each ACL explicitly defined so there was less "black magic" happening since you are defining actual ACLs, not an abstraction like a service.

However, I can see the benefit in allowing something like multiple operations.