devsisters / goquic

QUIC support for Go
http://devsisters.github.io/goquic/
BSD 3-Clause "New" or "Revised" License
944 stars 100 forks source link

./build_libs.sh issue with protobuf #33

Closed Eimji closed 8 years ago

Eimji commented 8 years ago

Hello,

When I run GOQUIC_BUILD=Release ./build_libs.sh, I get an error with protobuf:

ninja: Entering directory `libquic/build/release'
[7/728] Building CXX object CMakeFiles/quic.dir/src/net/quic/proto/source_address_token.pb.cc.o
FAILED: CMakeFiles/quic.dir/src/net/quic/proto/source_address_token.pb.cc.o 
/usr/bin/c++   -DUSE_OPENSSL -I../../src -I../../src/third_party/modp_b64 -I../../boringssl/include -I../../src/third_party/protobuf/src -Wall -fpic -std=gnu++11 -DNDEBUG -O3 -DNDEBUG -MMD -MT CMakeFiles/quic.dir/src/net/quic/proto/source_address_token.pb.cc.o -MF CMakeFiles/quic.dir/src/net/quic/proto/source_address_token.pb.cc.o.d -o CMakeFiles/quic.dir/src/net/quic/proto/source_address_token.pb.cc.o -c ../../src/net/quic/proto/source_address_token.pb.cc
../../src/net/quic/proto/source_address_token.pb.cc: In member function ‘void net::SourceAddressToken::MergeFrom(const net::SourceAddressToken&)’:
../../src/net/quic/proto/source_address_token.pb.cc:328:5: error: ‘MergeFromFail’ is not a member of ‘google::protobuf::internal’
     ::google::protobuf::internal::MergeFromFail(__FILE__, __LINE__);

I'm using protobuf from google (https://github.com/google/protobuf). Could you help me to overcome this issue ? Thanks.

hodduc commented 8 years ago

I found this issue too and updated libquic to use bundled protobuf files instead of generating them.