error saving playlist from queue

[6arms1leg]

clicking the save as playlist button i the queue (and entering a name) results in an error, shown in a red banner in the ui: "error saving playlist". a new tab is opened with the name "unsaved playlist" with all tracks in it. on the +tab in the playlist browser the playlist is created but empty.

[devsnd]

Cannot reproduce. Can you give me the output from the terminal cherrymusic is running in, and also the output from the web-developer console in the browser?

[6arms1leg]

Cannot reproduce.

have you tried my server or the new test server?

terminal stout:

[130219-15:15] 192.168.178.xx - - [19/Feb/2013:15:15:55] "POST /api/showplaylists HTTP/1.1" 200 2491 "http://server:port/" "Mozilla/5.0 (X11; Linux) AppleWebKit/537.6 (KHTML, like Gecko) Chrome/18.0.1025.133 Safari/537.6 Midori/0.4"
[130219-15:16] ERROR   : [19/Feb/2013:15:16:13] HTTP Traceback (most recent call last):
  File "/home/pi/cherrymusic-devel/cherrypy/_cprequest.py", line 656, in respond
    response.body = self.handler()
  File "/home/pi/cherrymusic-devel/cherrypy/lib/encoding.py", line 188, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/home/pi/cherrymusic-devel/cherrypy/_cpdispatch.py", line 34, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/pi/cherrymusic-devel/cherrymusicserver/httphandler.py", line 228, in api
    return handler(value)
  File "/home/pi/cherrymusic-devel/cherrymusicserver/httphandler.py", line 430, in api_saveplaylist
    playlisttitle=pl['playlistname']);
  File "/home/pi/cherrymusic-devel/cherrymusicserver/playlistdb.py", line 73, in savePlaylist
    numberedplaylist.append((playlistid, track, song['mp3'], song['title']))
KeyError: 'mp3'

[130219-15:16] 192.168.178.xx - - [19/Feb/2013:15:16:13] "POST /api/saveplaylist HTTP/1.1" 500 805 "http://server:port/" "Mozilla/5.0 (X11; Linux) AppleWebKit/537.6 (KHTML, like Gecko) Chrome/18.0.1025.133 Safari/537.6 Midori/0.4"

web console (midori):

refreshTabs playlistmanager.js:405
refreshTabs playlistmanager.js:405
refreshPlaylists playlistmanager.js:448
["pl-1361275849162", "pl-1361283370955"] playlistmanager.js:454
pl-1361275849162 playlistmanager.js:456
pl-1361283370955 playlistmanager.js:456
refreshTabs playlistmanager.js:405
refreshTabs playlistmanager.js:405
POST http://server:port/api/saveplaylist 500 (Internal Server Error)

[devsnd]

Okay, thanks for the report. This is is probably due to this bein the first playlist containing an ogg file ...

[6arms1leg]

ahhh, almost right. not ogg, but i accidently added a flac file, now that you mention it. i didnt realized that it was in flac format...

[devsnd]

Quick roadmap for the issue:

• [x] Move url translation for transcoded tracks just before setMedia command of jPlayer
• [x] rename field "mp3" in track-entity to avoid later confusion
• [x] make sure that older playlists can still be loaded (translate to newer format upon saving)