devsnd / cherrymusic

Stream your own music collection to all your devices! The easy to use free and open-source music streaming server.
http://www.fomori.org/cherrymusic
GNU General Public License v3.0
1.03k stars 187 forks source link

Downloading and displaying current song's lyrics #478

Open yonailo opened 9 years ago

yonailo commented 9 years ago

Hi,

Keep up the hard work guys, congratulations I am very happy since I have discovered your project.

I would like to propose a new feature. I am a big fan of lyrics, I mean they help me better understand the songs. It is a big big feature for me.

Wouldn't it be possible to download & display the lyrics of the current song at the left side pane ? I see that downloading artworks is already in place (and works very well), so the downloading of lyrics would not be so difficult...

Thank you.

devsnd commented 9 years ago

Hello Yanailo,

Thanks for you suggestion; It Indeed is possible to implement this feature, but right now both me and @tilboerner are quite busy and can only make the occasional fix for CM. :bus:

If you really want to see this feature done, I'd urge you to do the research for us needed to get it done: Compare different web services where many song lyrics are available. This is very important, since we don't want CM only to show lyrics of Britney Spears, but also some lesser known music. The best service might even offer an API (ready made access for other programs, like CM), which would be best. Also, If there is no API, and if you know some HTML, you might want to make sure that the site is properly structured, so we can easily grab the lyrics from it. Once you've compared different services, you can then show us the advantages and disadvantages of each of them and we'll write some code to try it out.

It's up to you! :tada:

yonailo commented 9 years ago

Hello,

I had got your message into SPAM sorry for my late answer.

I will take into account your suggestions, the problem is that I dont have very much spare time either. It is true that the best thing to do would be to have an API, if we can not find a lyric's site with a propre API I think it is not worth doing this.

I will come back to you if I find something. thank you very much.

On Wed, Sep 17, 2014 at 10:50 AM, Tom Wallroth notifications@github.com wrote:

Hello Yanailo,

Thanks for you suggestion; It Indeed is possible to implement this feature, but right now both me and @tilboerner https://github.com/tilboerner are quite busy and can only make the occasional fix for CM. [image: :bus:]

If you really want to see this feature done, I'd urge you to do the research for us needed to get it done: Compare different web services where many song lyrics are available. This is very important, since we don't want CM only to show lyrics of Britney Spears, but also some lesser known music. The best service might even offer an API (ready made access for other programs, like CM), which would be best. Also, If there is no API, and if you know some HTML, you might want to make sure that the site is properly structured, so we can easily grab the lyrics from it. Once you've compared different services, you can then show us the advantages and disadvantages of each of them and we'll write some code to try it out.

It's up to you! [image: :tada:]

— Reply to this email directly or view it on GitHub https://github.com/devsnd/cherrymusic/issues/478#issuecomment-55865819.

MrRKernelPanic commented 9 years ago

Dear All,

I too think this would be a great feature or perhaps use one already available, web based and maintained by someone else: What about the Lyrics By Rob plugin for Chrome / Firefox etc.

I approached him if he would be willing to consider adding support for Cherry Music and he sent this lovely Email back. I just wish I was clever enough to know the answers to any of these questions:


Hi Mark,

I'm open to supporting CherryMusic. In order to recognize and support the site, I need to know the answers to a few questions:

CM is open-source, so if there is no easy way to address any of the previous questions, then you could send a pull request to the Github repo, and have your answer ready :)

Once the answers are known, supporting the site is very straightforward. I plan on publishing an update very soon, so if you get back within a week or so, then the next update could contain CM support.

Kind regards, Rob https://robwu.nl

yonailo commented 7 years ago

Maybe a simpler option would be to read srt files like is done with movies?

yonailo commented 7 years ago

Or better read USLT Id3 tags (Unsynchronized lyric/text Transcription) directly from thé music file?