devsnd / cherrymusic

Stream your own music collection to all your devices! The easy to use free and open-source music streaming server.
http://www.fomori.org/cherrymusic
GNU General Public License v3.0
1.03k stars 187 forks source link

Crashes on start by failing to parse cherrypy version number #633

Closed Isgar closed 8 years ago

Isgar commented 8 years ago

Using Arch Linux and devel branch

Version numbering seems to differ on my system. The commit that broke it: https://github.com/devsnd/cherrymusic/commit/43856934a041bb65904d2459eb8bd120e4bdc706

Traceback (most recent call last):
  File "./cherrymusic", line 33, in <module>
    import cherrymusicserver
  File "/home/cherrymusic/cherrymusic/cherrymusicserver/__init__.py", line 167, in <module>
    cherrypy_version = tuple(int(v) for v in cherrypy.__version__.split('.'))
  File "/home/cherrymusic/cherrymusic/cherrymusicserver/__init__.py", line 167, in <genexpr>
    cherrypy_version = tuple(int(v) for v in cherrypy.__version__.split('.'))
ValueError: invalid literal for int() with base 10: 'post20160705'

For the time being, I have changed the line to cherrypy_version = (5, 5) which also solves #632

Looks like the cherrypy version number is not reliable

devsnd commented 8 years ago

Ah shit, I tried many different versions on the continuous integration platform...

Looks like the cherrypy version number is not reliable

Yeah, looks like it. I guess I should not rely on the version at all and instead try to figure out the version of the lib using other means :cry:

Sorry for breaking your install twice in a row, I will release a fix version this evening! And thanks for reporting!

Isgar commented 8 years ago

Don't worry about breaking it, I'm glad I can help this awesome project in some way ;)

devsnd commented 8 years ago

Damn, I just didn't find the time to do the fix... I have so little time, I didn't even update my own homeserver to the latest version yet :crying_cat_face:

screenshot - 18 07 2016 - 10 23 47

The fix is still somewhere near the top of my to-do list!

devsnd commented 8 years ago

@Isgar Damn, I am the worst software maintainer of all time. Sorry it took me three weeks to do this little fix! I released a new version containing the fix! (0.37.1)