search

devsnd / cherrymusic

Stream your own music collection to all your devices! The easy to use free and open-source music streaming server.
http://www.fomori.org/cherrymusic
GNU General Public License v3.0
1.03k stars 187 forks source link

Itunes artwork #636

Closed mattss closed 8 years ago

mattss commented 8 years ago

This adds a number of album artwork related changes.

  1. Use iTunes API for album artwork

    The iTunes API gave me better results in my own testing, and also avoids the 'Prime' labels you get all over your artwork when using Amazon.

  2. Use metadata from files when fetching artwork for a directory

    Previously, the artwork fetcher relied on you having an accurate album name in the containing folder. This often didn't work well for me, as my music was arranged in an Artist / Album structure, meaning that generic album names often resulted in the wrong artist match. This now tries to use the metadata from the first file in a directory to get the correct album and artist names.

  3. Only filter directory names when looking for artwork

    Previously, the artwork fetcher stripped all numbers from keywords sent to it. This meant that albums or artists with numbers in them frequently returned incorrect or no results. I've moved this filtering to the level above, so that directories have numbers removed (in case you number your directories), but the metadata from change 2) above is used verbatim.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 73.38% when pulling 4ab11292d4052b27e85e52d063d7b459b0d31d8b on mattss:itunes-artwork into 08f81567aa34357da08523ed59b32e16c6369d67 on devsnd:devel.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.05%) to 73.499% when pulling 4aee05b209c835c10a1df6acb8c9c198e7337981 on mattss:itunes-artwork into 08f81567aa34357da08523ed59b32e16c6369d67 on devsnd:devel.

devsnd commented 8 years ago

Hey Matthew!

Thanks so much fior the very nice pull request. You have everything arranged nicely already. Thanks :santa:

I'm sorry my response time is so bad lately. I'm really busy at work and in private as well, so I don't have all the time CM requires :cry:

I will release the new version shortly!

mattss commented 8 years ago

@devsnd No problems I fully understand having a life outside github! Thanks for the merge.

devsnd commented 8 years ago

Hey Matthew!

I have released version 0.38.0 which includes your features. Thanks again for the pull request. I made some small changes, so it will not only try the first file in the directory, but up to 10 files.

see here: https://github.com/devsnd/cherrymusic/commit/cb191975ee52d5910560215f66722a37e5d41e3e

thanks again for the really nicely presented pull-request, have a nice day, tom

mattss commented 8 years ago

Great stuff - thanks for letting me know 👍