search

devsnd / cherrymusic

Stream your own music collection to all your devices! The easy to use free and open-source music streaming server.
http://www.fomori.org/cherrymusic
GNU General Public License v3.0
1.03k stars 187 forks source link

Change default left-side screen to be file browser instead of empty search results #680

Closed MaxLeiter closed 7 years ago

MaxLeiter commented 7 years ago

streamlines the process of playing music and makes more sense

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.554% when pulling b0babb83986d8d9a360a6a2bbbab4af3e8570138 on MaxLeiter:first-screen into 3d533b362fa91d4a240a665c53b6085072b279c1 on devsnd:devel.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.554% when pulling b0babb83986d8d9a360a6a2bbbab4af3e8570138 on MaxLeiter:first-screen into 3d533b362fa91d4a240a665c53b6085072b279c1 on devsnd:devel.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.554% when pulling b0babb83986d8d9a360a6a2bbbab4af3e8570138 on MaxLeiter:first-screen into 3d533b362fa91d4a240a665c53b6085072b279c1 on devsnd:devel.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.554% when pulling b0babb83986d8d9a360a6a2bbbab4af3e8570138 on MaxLeiter:first-screen into 3d533b362fa91d4a240a665c53b6085072b279c1 on devsnd:devel.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.554% when pulling b0babb83986d8d9a360a6a2bbbab4af3e8570138 on MaxLeiter:first-screen into 3d533b362fa91d4a240a665c53b6085072b279c1 on devsnd:devel.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 73.554% when pulling b0babb83986d8d9a360a6a2bbbab4af3e8570138 on MaxLeiter:first-screen into 3d533b362fa91d4a240a665c53b6085072b279c1 on devsnd:devel.

MaxLeiter commented 7 years ago

@devsnd no clue what happened here with @coveralls ...

devsnd commented 7 years ago

Hey Max, thanks for the PR. Unfortunately I cannot accept it because loading the file browser directly will hide the "message of the day".

For normal users it contains the "useless wisdom" (which in fact is really useless) but for admins it will contain information about new updates of CM. These would then be hidden from them. These updates might contain important security fixes, which should be clearly visible.

MaxLeiter commented 7 years ago

what if it checks if the user is admin? Alternatively, a modal could pop up. Users shouldn't suffer for the sake of the admin.