search

devsnd / cherrymusic

Stream your own music collection to all your devices! The easy to use free and open-source music streaming server.
http://www.fomori.org/cherrymusic
GNU General Public License v3.0
1.03k stars 189 forks source link

Removed cherrymusicserver imports from setup.py #697

Closed rjsberry closed 6 years ago

rjsberry commented 6 years ago

Fixes #695.

I'd propose to go completely wild and parse the file manually to find the lines (and strings) that correspond to these variables.

Rather than just do this for VERSION and DESCRIPTION I added a function to get a global string by parsing a file relative to setup.py and used this for shareFolder too.

The RE works for both single and double quoted strings.

Tested with 3.6.2 and 2.7.13 clean venv's.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 73.491% when pulling 6662b5641a6647641a1e599df42fad809c065adb on rjsberry:pip_fix into aa4eea153b96537383af336fccfb0cd9beee3ceb on devsnd:devel.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 73.609% when pulling 8f43b64874b99a40dd354f767463cedbf276c723 on rjsberry:pip_fix into aa4eea153b96537383af336fccfb0cd9beee3ceb on devsnd:devel.

devsnd commented 6 years ago

Looks good to me, thanks a lot Richard!

As a small reward, have some dancing midgets 💃 🕺 👯