Removed deprecated call to timeout_monitor

devsnd / cherrymusic

Stream your own music collection to all your devices! The easy to use free and open-source music streaming server.

http://www.fomori.org/cherrymusic

GNU General Public License v3.0

1.03k stars 189 forks source link

Removed deprecated call to timeout_monitor #708

Closed TangoSierraAlfaVI closed 6 years ago

TangoSierraAlfaVI commented 6 years ago

Fixes #704

As stated in the initial issue, CherryPy v12.0.0 removed support for timeout_monitor, causing crashes if using a version >=12.0.0. Maybe it's naive of me to think that the problem could be solved just by removing the line, but at the very least it went from unusable to seemingly stable. That said, I'm not familiar with the codebase yet, so I'd be happy to go for a different solution if someone points out that this is causing behind-the-scenes problems.

coveralls commented 6 years ago

Coverage increased (+0.05%) to 73.597% when pulling 15973f3f4c22360c44ae9559c3ef71e5279a23db on TangoSierraAlfaVI:remove-timeout-monitor into 08019c960ad151559c9d5f1d8dbac359cccd1de8 on devsnd:devel.

tilboerner commented 6 years ago

Closing + reopening to trigger new CI build with new travis config from upstream.

tilboerner commented 6 years ago

@devsnd I think we can just merge this. I tried on an older cherrypy with and without the setting, and it didn't seem to make a difference in the browsersetup process: both works, and takes about the same time.

@TangoSierraAlfaVI Thanks a lot for your contribution! 🌻