Add support for Serenity LibJS

devsnek / esvu

esvu is your one-stop shop for all implementations of ECMAScript.

MIT License

179 stars 23 forks source link

Add support for Serenity LibJS #33

Closed alimpfard closed 2 years ago

alimpfard commented 2 years ago

Only for linux-x86_64 for the time being.

Things I'm not so sure about (would like some comments on, at least):

Getting workflow artifacts out of github is a damn chore (find artifact ID, find run ID, then use nightly.link because github doesn't allow public access...)
Is the script being named js acceptable, or should we switch to something like serenity-js?

devsnek commented 2 years ago

I think giving it a different name would be good. Also, you should run the linter. I just updated the github workflow to also run tests on pull requests.

alimpfard commented 2 years ago

I've fixed the eslint issues (didn't notice there was a config, sorry), and renamed the registered script to serenity-js.

devsnek commented 2 years ago

looks good. also i forgot, can you also update the readme?

alimpfard commented 2 years ago

@devsnek: is there anything left for merging this, or is it good to go?

IdanHo commented 2 years ago

@devsnek Is it possible to bump the esvu version? I'd like to use this without cloning directly