search

devsnek / esvu

esvu is your one-stop shop for all implementations of ECMAScript.
MIT License
179 stars 23 forks source link

fix graaljs engine installer #42

Closed woess closed 2 years ago

woess commented 2 years ago

fixes https://github.com/devsnek/esvu/issues/38 by registering the required libjsvm.so asset, fixes paths for darwin-* and *-arm64, and marks the graaljs engine as supported again.

devsnek commented 2 years ago

these assets were removed previously (see https://github.com/devsnek/esvu/commit/a7c722df0f1c31e0830a38e55feb6049d5ca9246). if they're going to stick around for a good while this time, I'm ok with reenabling graaljs but I just wanna double check this.

woess commented 2 years ago

@devsnek can you clarify why you removed these assets? I'm not aware of any recent changes in graaljs standalone distribution. So if the files were not there, perhaps the installer picked one of our 21.3. updates instead of the latest 22. release.

devsnek commented 2 years ago

@woess I received a bug report from test262 that graal was not installing and when I investigated, those files were missing. Maybe y'all could double check that the rest of the installer logic for graal is correct, and once that's verified we can re-enable it.

woess commented 2 years ago

I see. I think indeed it just picks the last published release artifact from github which may not be the latest major version. I'll rework the code to figure out the correct latest version and then update this PR.

woess commented 2 years ago

@devsnek please review the PR when you have time. thanks!

devsnek commented 2 years ago

@woess you'll need to update this for the linter. locally i believe you can do npm run lint

woess commented 2 years ago

@devsnek I've fixed the lint.