devsnek / esvu

esvu is your one-stop shop for all implementations of ECMAScript.
MIT License
178 stars 23 forks source link

GraalJS and QuickJS will not install #6

Closed rwaldron closed 4 years ago

rwaldron commented 4 years ago

Should these engines be included when running esvu --engines=all? Presently they do not install:

$ cat status.json
{
  "selectedEngines": [
    "ch",
    "engine262",
    "jsc",
    "jsshell",
    "v8",
    "xs"
  ],
  "installed": {
    "ch": {
      "version": "1_11_16",
      "binEntries": [
        "chakra"
      ]
    },
    "engine262": {
      "version": "0.0.1-587a1fa64b42201eccc48280a07b36bbb4f40b7e",
      "binEntries": [
        "engine262"
      ]
    },
    "jsc": {
      "version": "257719",
      "binEntries": [
        "javascriptcore",
        "jsc"
      ]
    },
    "jsshell": {
      "version": "74.0b9",
      "binEntries": [
        "sm",
        "spidermonkey"
      ]
    },
    "v8": {
      "version": "8.2.230",
      "binEntries": [
        "v8"
      ]
    },
    "xs": {
      "version": "10.0.0",
      "binEntries": [
        "xs"
      ]
    }
  }
}
rwaldron in ~/.esvu/engines
$ ls
.
├── [drwxr-xr-x rwaldron staff      96 Mar  2 14:25]  ch/
├── [drwxr-xr-x rwaldron staff      96 Mar  2 14:25]  engine262/
├── [drwxr-xr-x rwaldron staff      96 Mar  2 14:25]  jsc/
├── [drwxr-xr-x rwaldron staff     160 Mar  2 14:26]  jsshell/
├── [drwxr-xr-x rwaldron staff     160 Mar  2 14:26]  v8/
└── [drwxr-xr-x rwaldron staff      96 Mar  2 14:26]  xs/
devsnek commented 4 years ago

graaljs is disabled by default because the download us absolutely massive (500mb). quickjs is only supported on linux64, I'd guess you're not using linux64.

all+graaljs will include graaljs (or just esvu install graaljs)

rwaldron commented 4 years ago

Looks like QuickJS installs on our CI system, which is "linux64", but GraalJS does not. I will try your suggestion—thanks!

devsnek commented 4 years ago

@rwaldron is this resolved?

rwaldron commented 4 years ago

@devsnek good enough for me, yes. Thanks!