bower install allow-root

devsoap / ds-gradle-vaadin

Gradle plugin for building Vaadin Flow 10/11/12/13/14/15 apps

https://devsoap.com/gradle-vaadin-flow-plugin

Other

36 stars 13 forks source link

bower install allow-root #288

Closed tembi4-84 closed 4 years ago

tembi4-84 commented 4 years ago

--allow-root for bower installation to prevent fails inside Docker containers

CLAassistant commented 4 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: johndevs
:x: ArtemPopenkov
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

johndevs commented 4 years ago

Hi @tembi4-84 ,

I updated your PR with the latest changes for master.

If you could sign the CLA (by clicking on the details link) then I can merge this into the master branch.

tembi4-84 commented 4 years ago

Hi @johndevs, I had signed it (You have signed the CLA for devsoap/gradle-vaadin-flow Version: 2018-09-14), but in the PR it still says "NOT signed"...

tembi4-84 commented 4 years ago

@johndevs

johndevs commented 4 years ago

This is strange. I'll rebase the change and see if it would make a difference.

It can also be that if you are using multiple Github accounts that somehow the signature was given with the wrong account (https://github.com/cla-assistant/cla-assistant/issues/241). In that case try to sign it again using another browser window where you haven't signed in to Github before.