devsoc-unsw / freerooms

A web application designed to aid UNSW students in finding vacant rooms.
https://freerooms.devsoc.app/
Other
18 stars 1 forks source link

fix: use 100% height over 100vh so it works on mobile #367

Closed francojreyes closed 1 year ago

francojreyes commented 1 year ago

We've generally used height: "100vh" or height: "calc(100vh - ${navHeight}px)" to size the main the body of the site so that it fills the whole screen. However, on mobile 100vh actually includes the browser search bar which is not part of the website (obviously), so it would overflow the screen and require you to scroll. Using 100% avoids this problem.