Added and applied ESLint and Prettier

devsoc-unsw / freerooms

A web application designed to aid UNSW students in finding vacant rooms.

https://freerooms.devsoc.app/

Other

19 stars 1 forks source link

Added and applied ESLint and Prettier #429

Closed JessicaF closed 6 months ago

JessicaF commented 6 months ago

Updated configuration for ESLint and Prettier
Applied both ESLint and Prettier to the frontend folder
Removed pnpm from frontend because I don't like it and we have npm already

Can both reviewers please check my changes work and haven't messed stuff up - ty!

JessicaF commented 6 months ago

@francojreyes Can we change the CI actions to not use pnpm? Or more broadly, why are we using pnpm in the first place?

francojreyes commented 6 months ago

@JessicaF yeah, feel free to remove pnpm. We're using it because that's how it's been since 2021 idk lol. I think it feels faster than npm personally. If you want me to update CI to use npm instead I can, or u can do it urself.

Also, if you're doing things like adding prettier/removing pnpm can you do it for both fe/be? I think it'll be annoying to have to switch between workflows.

JessicaF commented 6 months ago

@francojreyes I've configured Prettier and ESLint for the backend as well. Docs are updated on how to use them too.

Yeah can you update the CI to use npm, or you can tell me where to change that stuff and I'll try?

francojreyes commented 6 months ago

@JessicaF I'll try do, I couldn't tell you where to change stuff cos im not rly sure myself lmao