search

devsoc-unsw / freerooms

A web application designed to aid UNSW students in finding vacant rooms.
https://freerooms.devsoc.app/
Other
18 stars 1 forks source link

bug: Fix warning - Received `true` for a non-boolean attribute `isalternate` #459

Closed JessicaF closed 1 month ago

JessicaF commented 3 months ago

When running the frontend, a warning in the terminal is shown: 

Warning: Received `true` for a non-boolean attribute `isalternate`.
SkellyBG commented 2 months ago

while looking at nextjs bundle analyze, I spent sometime digging and fixed this error ^^

https://github.com/emotion-js/emotion/issues/2193

JessicaF commented 1 month ago

@SkellyBG Thanks for looking into this! 🙌 Did you end up making a PR with a workaround? How did you end up fixing it?

SkellyBG commented 1 month ago

I haven't made a PR yet - the change still live in another branch that I was using to try speeding up next dev: https://github.com/devsoc-unsw/freerooms/compare/dev...skelly/idk-what-im-doing#diff-3b4a40a8d1dac988639aaef4828e986d6cf8997db36925d90d882c3ce5134d68R71-R78

I'll split the change to a different branch and make a PR for it ^^

JessicaF commented 1 month ago

@SkellyBG Hahaha the branch and commit names 🤣🤣 But yes please split it into a different branch following the naming conventions and make a PR when ready 😊

Much appreciate you taking the initiative to make improvements!