461 - Fix building room pages being cut-off on mobile views

devsoc-unsw / freerooms

A web application designed to aid UNSW students in finding vacant rooms.

https://freerooms.devsoc.app/

Other

19 stars 1 forks source link

461 - Fix building room pages being cut-off on mobile views #471

Closed marktran2 closed 5 months ago

marktran2 commented 6 months ago

Summary of changes

previously had the mobile view of a room page cut off:
now has been fixed so that after the small mobile breakpoint is crossed, the room page will take up the whole page width instead of having it fixed to 400px

Viewing changes

run branch locally and have the app in a mobile view (< 600px wide) and click on any building to see card

richard-xue-vrx commented 6 months ago

This looks good to me! On a completely unrelated note, there's a slight issue with the time box not taking up the full space when expanding from 400px to 600px width, but that's something for another time/a matter of opinion on what looks good.

JessicaF commented 6 months ago

@marktran2 Could you please add some tests for the BuildingDrawer file? Can just be simple tests checking that some expected text shows up with some basic mocked data

Otherwise the functionality looks good to me!

marktran2 commented 5 months ago

@JessicaF added tests just recently. Please lmk what u think!