Closed sobariu closed 2 months ago
@sobariu Don't forget to add Richard and I as reviewers so we get notified about it via email 😎
Hi, I pushed new changes to the branch.
RoomAvailabilityBox
component that was declared in BuildingDrawer.tsx
.package-lock.json
file, I don't recall making any changes to the file, so I am unsure why it says i did. I double checked the file with the one in the main branch and nothing has changed.
- In terms of the
package-lock.json
file, I don't recall making any changes to the file, so I am unsure why it says i did. I double checked the file with the one in the main branch and nothing has changed.
Looks like you're adding a package-lock.json
file to the monorepo root (the package-lock.json
file in the frontend isn't touched!) - you may have accidentally run npm install
in the root folder instead? In any case, you should remove it from the diff.
- In terms of linting, my VSCode says there's no error, although that might be because of how my VSCode is set. I ran npm run lint to double check.
Lints seem fine on my VSCode too - @JessicaF could you send the error that your VSCode is having?
- In terms of the
package-lock.json
file, I don't recall making any changes to the file, so I am unsure why it says i did. I double checked the file with the one in the main branch and nothing has changed.Looks like you're adding a
package-lock.json
file to the monorepo root (thepackage-lock.json
file in the frontend isn't touched!) - you may have accidentally runnpm install
in the root folder instead? In any case, you should remove it from the diff.
Oh thank you for that! I probably did run npm install in the root folder by accident ;-; I made a new push that removes this file :)))
Before, the "Available Soon" text was formatted weirdly because the text was overflowing, and so that's why it takes up two lines rather than just one. This can be reproduced if you go to webster building and set time to 6/3/2024 3:25PM.
This was the image of how it looked before:
I added a line of code that basically sets the text of the status of the rooms to be "nowrap", so it doesn't get the weird formatting.
whiteSpace: "nowrap"
This is how it looks now:In terms of testing, I struggled a bit here to test with BuildingDrawer component because I had to render with redux, but then it couldn't fetch the data of the rooms. Therefore, I had to make a new file in
views
calledRoomAvailabilityBox.tsx
, which allowed me to export the 'RoomAvailabilityBox` component and test it directly.Note though that I didn't really delete any code from
BuildingDrawer.tsx
, so there's duplicate code inRoomAvailabilityBox.tsx
andBuildingDrawer.tsx
.