devspace-sh / devspace

DevSpace - The Fastest Developer Tool for Kubernetes ⚡ Automate your deployment workflow with DevSpace and develop software directly inside Kubernetes.
https://devspace.sh
Apache License 2.0
4.3k stars 360 forks source link

devx: Warn when the `values` field incorrectly contain dots #1476

Open arcanis opened 3 years ago

arcanis commented 3 years ago

Is your feature request related to a problem?

I was installing the following chart: https://github.com/bitnami/charts/tree/master/bitnami/rabbitmq/

As you can see, it requires setting a few parameters:

Naturally, that's what I did in my devspace.yaml:

values:
  auth.username: foo
  auth.password: bar

And I spent two evenings trying to figure out why the hell I couldn't connect to the instance, and thinking it was due to some lingering Helm cache somewhere, deleting and recreating everything I could, when the problem simply was that the syntax was incorrect (which I noticed by printing the content of the values.yml file you generate, and comparing with the bitnami defaults).

Which solution do you suggest?

One of those two:

/kind feature

FabianKramm commented 3 years ago

@arcanis thanks for creating this issue! I agree that can be quite confusing, we could add a warning if something like this is encountered during deploy to notify the user of a potential mistake, but crashing or converting the dots automatically is probably not something we want, as it is possible in the values.yaml of helm itself to define such constructs (although very very rare I agree). Hence it would limit expressibility and if a chart would use such a construct it would be incompatible with DevSpace.