devspace-sh / devspace

DevSpace - The Fastest Developer Tool for Kubernetes ⚡ Automate your deployment workflow with DevSpace and develop software directly inside Kubernetes.
https://devspace.sh
Apache License 2.0
4.28k stars 359 forks source link

If a "var" is set as password it should be masked on outputs and logs #1513

Open leventogut opened 3 years ago

leventogut commented 3 years ago

vars:

LOGS>> info] Execute hook 'sh -c while ! mysql -u root -p"db.root.password/" -e ";" >/dev/null 2>&1 ; do echo "Waiting for database to be ready..."; sleep 3; done

echo "CREATE USER IF NOT EXISTS 'laravel'@'%' IDENTIFIED BY 'db.password'; ALTER USER 'laravel' IDENTIFIED BY 'db.password';" | mysql -u root -p'db.root.password/' ' [info] Waiting for running containers for hook 'sh -c while ! mysql -u root -p"db.root.password/" -e ";" >/dev/null 2>&1 ; do echo "Waiting for database to be ready..."; sleep 3; done

echo "CREATE USER IF NOT EXISTS 'laravel'@'%' IDENTIFIED BY 'db.password'; ALTER USER 'laravel' IDENTIFIED BY 'db.password';" | mysql -u root -p'db.root.password/' ' [info] Execute hook 'sh -c while ! mysql -u root -p"db.root.password/" -e ";" >/dev/null 2>&1 ; do echo "Waiting for database to be ready..."; sleep 3; done

echo "CREATE USER IF NOT EXISTS 'laravel'@'%' IDENTIFIED BY 'db.password'; ALTER USER 'laravel' IDENTIFIED BY 'db.password';" | mysql -u root -p'db.root.password/'

FabianKramm commented 3 years ago

@leventogut thanks for creating this issue! Yes makes sense, I think we can add this