search

devspace-sh / devspace

DevSpace - The Fastest Developer Tool for Kubernetes ⚡ Automate your deployment workflow with DevSpace and develop software directly inside Kubernetes.
https://devspace.sh
Apache License 2.0
4.36k stars 361 forks source link

Files not deleted using mirrorLocal inital sync #1578

Open kickthemooon opened 3 years ago

kickthemooon commented 3 years ago

What happened? Using mirrorLocal (default) initial sync, files, which are locally non-existent, were not deleted from remote because that directory was specified in the downloadExcludePaths.

What did you expect to happen instead? That, if mirrorLocal is used, those files will be deleted because they are not specified in the list of uploadExcludePaths

How can we reproduce the bug? (as minimally and precisely as possible) use mirrorLocal initial sync strategy have a directory on remote as well as locally present have a file in that directory on remote which is not present locally add the directory path to downloadExcludePaths start devspace sync

Local Environment:

Kubernetes Cluster:

Anything else we need to know? After I remove the directory from downloadExcludePaths the files get deleted which are not present locally

/kind bug

FabianKramm commented 3 years ago

@kickthemooon thanks for creating this issue! Yes you are correct, we should change this.