search

devspace-sh / devspace

DevSpace - The Fastest Developer Tool for Kubernetes ⚡ Automate your deployment workflow with DevSpace and develop software directly inside Kubernetes.
https://devspace.sh
Apache License 2.0
4.28k stars 359 forks source link

Allow adjusting devspace config on run_default_pipeline #2044

Closed hendrikheil closed 1 year ago

hendrikheil commented 2 years ago

Is your feature request related to a problem? As discussed in the Slack channel, with devspace 6.0.0-alpha.13 there is currently only create_deployment [name] --from-file file.yaml to adjust the helm values on a pipeline run. This works and is generally fine, however it forces a user to overwrite the default (in my case dev) pipeline to achieve a relatively simple goal. I personally think it would be great if we could apply config patches on a devspace dev run without overwriting a default pipeline.

Which solution do you suggest? @LukasGentele suggested a --set flag for run_default_pipeline which could adjust the config without duplicating the default pipeline definition. With this approach it would probably be a good idea to also allow --set-from-file (or similar) as to not have huge pipeline definitions when there are more things to adjust.

Which alternative solutions exist? Alternatively allowing dev to define patches for a devspace dev run, similar to how profile patches work could work. I however I could see both options as being worthwhile to implement.

Additional context https://loft-sh.slack.com/archives/CDSV29U85/p1650347170419019

/kind feature

FabianKramm commented 2 years ago

@CiiDyR thanks for the issue! After internal discussions we have decided to add the --set flag to run_default_pipeline as well as run_pipelines that modifies the current config that will be passed to the pipeline execution.