devspace-sh / devspace

DevSpace - The Fastest Developer Tool for Kubernetes ⚡ Automate your deployment workflow with DevSpace and develop software directly inside Kubernetes.
https://devspace.sh
Apache License 2.0
4.19k stars 351 forks source link

Underscores no longer allowed in devspace commands in v6 #2132

Closed rmcclaincf closed 2 years ago

rmcclaincf commented 2 years ago

What happened?
Upgraded to v6. Underscores no longer allowed in devspace commands. Switching it to dashes worked.

What did you expect to happen instead?
Underscores allowed.

How can we reproduce the bug? (as minimally and precisely as possible)

commands:
- name: init_single_partition_topics
  command: ./kafka/init-topics.sh PARTITIONS=1 REPLICATION=1 TOPICS=db.al.predictions,db.builder.units,db.workflows.all.tables,db.workflows.datauploads,scriptsapi.transform.from.workflows.to.scriptsapi,wfp.processed.datalines.from.scripts,scriptsapi.transform.dead.letters.from.workflows,scriptsapi.transform.test.dead.letters,scriptsapi.transform.test.to.scriptsapi,scriptsapi.transform.test.from.scriptsapi,job.archive.commands

My devspace.yaml:

version: v1beta11
Rest not included.
...

Local Environment:

Kubernetes Cluster:

Anything else we need to know?
No

/kind bug

FabianKramm commented 2 years ago

@rmcclaincf thanks for creating this issue! Yes we can allow underscorces again for commands