`labelSelector` with `containers:` and an inaccessible image fails

[SohumB]

What happened?

Under normal circumstances, if you provide a chart that renders to an image that's inaccessible, devspace will install that chart, then check any devImage replacements that needs to be done, then check if the pod is ready. When a labelSelector is specified with a containers: entry (as opposed to just assuming there's a single container), the latter two steps seem to be reversed, which means devspace waits forever on the ImagePullBackOff errors on the inaccessible image.

What did you expect to happen instead?

That to not happen :)

How can we reproduce the bug? (as minimally and precisely as possible)

My devspace.yaml:

version: v2beta1
name: app

pipelines:
  dev:
    run: |-
      create_deployments --all
      start_dev app

deployments:
  app:
    helm:
      chart:
        name: component-chart
        repo: https://charts.devspace.sh
      values:
        containers:
          - image: registry.gitlab.com/inaccessible/image

dev:
  app:
    labelSelector: 
      app.kubernetes.io/component: app
    containers:
      c0:
        container: container-0
        devImage: ghcr.io/loft-sh/devspace-containers/alpine:3
        terminal:
          command: bash --norc
        ssh: 
          enabled: true

If you try this devspace.yaml with an imageSelector, or with a labelSelector but no containers: map, it succeeds.

Local Environment:

• DevSpace Version: devspace version 6.0.0-beta.4
• Operating System: linux
• ARCH of the OS: AMD64
• Kubernetes cluster: minikube
• Kubernetes version:

  Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.6", GitCommit:"ad3338546da947756e8a88aa6822e9c11e7eac22", GitTreeState:"clean", BuildDate:"2022-04-14T08:49:13Z", GoVersion:"go1.17.9", Compiler:"gc", Platform:"linux/amd64"}
  Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:18:48Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"linux/amd64"}

/kind bug

[FabianKramm]

@SohumB thanks for creating this issue! The problem is in the documentation, if you have a single container you can do:

dev:
  app:
    labelSelector: 
      app.kubernetes.io/component: app
    container: container-0
    devImage: ghcr.io/loft-sh/devspace-containers/alpine:3
    terminal:
      command: bash --norc
     ssh: 
       enabled: true

and if you have multiple containers you need to do:

version: v2beta1
name: app

pipelines:
  dev:
    run: |-
      create_deployments --all
      start_dev app

deployments:
  app:
    helm:
      chart:
        name: component-chart
        repo: https://charts.devspace.sh
      values:
        containers:
          - image: registry.gitlab.com/inaccessible/image

dev:
  app:
    labelSelector: 
      app.kubernetes.io/component: app
    containers:
      container-0:
        devImage: ghcr.io/loft-sh/devspace-containers/alpine:3
        terminal:
          command: bash --norc
        ssh: 
          enabled: true

[SohumB]

Ah, I see! Thank you for the help!