search

devspace-sh / devspace

DevSpace - The Fastest Developer Tool for Kubernetes ⚡ Automate your deployment workflow with DevSpace and develop software directly inside Kubernetes.
https://devspace.sh
Apache License 2.0
4.28k stars 359 forks source link

Empty Function causes SegFault #2245

Closed ethankhall closed 2 years ago

ethankhall commented 2 years ago

What happened? 

> devspace print
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x105d20938]

goroutine 1 [running]:
github.com/loft-sh/devspace/pkg/devspace/config/versions.adjustConfig(0x140007f8690)
        /Users/runner/work/devspace/devspace/pkg/devspace/config/versions/adjust.go:26 +0x2c8
github.com/loft-sh/devspace/pkg/devspace/config/versions.Parse(0x1400055c2d0, {0x106a41100, 0x1082bbd20})
        /Users/runner/work/devspace/devspace/pkg/devspace/config/versions/versions.go:167 +0x420
github.com/loft-sh/devspace/pkg/devspace/config/loader.fillVariablesAndParse({0x1069f1b28, 0x140010b3860}, {0x106a16220, 0x1400067b280}, 0x1400055c2d0, {0x106a41100, 0x1082bbd20}, {0x10826be00, 0x17, 0x17})
        /Users/runner/work/devspace/devspace/pkg/devspace/config/loader/parser.go:134 +0xb0
github.com/loft-sh/devspace/pkg/devspace/config/loader.fillVariablesExcludeAndParse(...)
        /Users/runner/work/devspace/devspace/pkg/devspace/config/loader/parser.go:124
github.com/loft-sh/devspace/pkg/devspace/config/loader.(*commandsPipelinesParser).Parse(0x14001a87428, {0x1069f1b28, 0x140010b3860}, 0x140006177a0, 0x140005d62a0, {0x106a16220, 0x1400067b280}, {0x106a41100, 0x1082bbd20})
        /Users/runner/work/devspace/devspace/pkg/devspace/config/loader/parser.go:48 +0xf4
github.com/loft-sh/devspace/cmd.(*RawConfig).Parse(0x14000180190, {0x1069f1b28, 0x140010b3860}, 0x140006177a0, 0x140005d62a0, {0x106a16220, 0x1400067b280}, {0x106a41100, 0x1082bbd20})
        /Users/runner/work/devspace/devspace/cmd/root.go:359 +0xec
github.com/loft-sh/devspace/pkg/devspace/config/loader.(*configLoader).parseConfig(0x14000641430, {0x1069f1b28, 0x140010b3860}, 0x140006177a0, {0x106a314e0, 0x140003cfa40}, {0x0, 0x0}, {0x0, 0x0}, ...)
        /Users/runner/work/devspace/devspace/pkg/devspace/config/loader/loader.go:341 +0x35c
github.com/loft-sh/devspace/pkg/devspace/config/loader.(*configLoader).LoadWithParser(0x14000641430, {0x1069f1af0, 0x140001a3e00}, {0x0, 0x0}, {0x0, 0x0}, {0x1069b7780, 0x14000180190}, 0x14000180280, ...)
        /Users/runner/work/devspace/devspace/pkg/devspace/config/loader/loader.go:175 +0x6ac
github.com/loft-sh/devspace/cmd.parseConfig({0x106a35c38, 0x1082bc2f8})
        /Users/runner/work/devspace/devspace/cmd/root.go:326 +0x20c
github.com/loft-sh/devspace/cmd.BuildRoot({0x106a35c38, 0x1082bc2f8}, 0x0)
        /Users/runner/work/devspace/devspace/cmd/root.go:188 +0x17c
github.com/loft-sh/devspace/cmd.Execute()
        /Users/runner/work/devspace/devspace/cmd/root.go:132 +0x60
main.main()
        /Users/runner/work/devspace/devspace/main.go:20 +0xf0

What did you expect to happen instead?

To give an error.

How can we reproduce the bug? (as minimally and precisely as possible)

My devspace.yaml:

version: v2beta1
pipelines:
  after_dependency_background: |-
    on-after-deploy-container-ready-local
  pipelines:
  dev: |-
  ....

Local Environment:

/kind bug

FabianKramm commented 2 years ago

@ethankhall thanks for reporting this issue! Will be fixed in the next release!